Repository navigation
Conversation
Update Master for compiliing new MICADO package
Release MICADO 2023-03-08
Summer 2023 release
Mostly updates to MICADO package
Mostly adaption following the off-by-one fix
Prepare for new package release
Merge dev_master in preparation for release
Merge dev_master in preparation for release
Merge dev_master in preparation for release
Using best-guess values for MICADO, for METIS taken from: AstarVienna#356 (comment) Closes AstarVienna#356, except the LMS extended mode, which is not yet implemented anyway (also set the status to concept for that).
The additional diff comes from stripped whitespace or newlines.
…dded TEL.area default to MICADO MCA mode.
These allow the "full detector array" mode to be a "first-order- configurable", i.e. can be set via `properties`, instead of having to switch the `.include` on the two effects after instantiating the optical train. The latter still works, so this is fully backwards compatible.
… configurations** - Included `sloan_u.dat` and `sloan_z.dat` filters in ZImager optics files. - Added filter wheel selector with support for `g`, `r`, `i` filters in `ZShooter_IMAGER.yaml`. - Updated dichroic tree structure with revised `z_order` values. - Changed selector key for wheels and quantum efficiency curves to `image_plane_id`.
This reverts commit aefd527.
Keep the explicit Zemax grating angles and detector rotations. Record fixed positions in mm: R moves left 150 pixels, H left 130, and YJ up 50 relative to comparison row 2; B, G and K keep their positions. Document the temporary YJ order-57 exclusion without recentering retained orders. Validation: all 23 retained YJ orders and all 10 H orders fit their full FSR and slit ends; 17 of 20 R orders fit completely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by the focused Caltech review series, whose final existing entry in this repository is #17. The final focused review tip retains the same production instrument files; its only baseline difference is the repaired detector-test fixtures.
New development continues in #18, based on that review history.
Closing this broad PR without merging to leave one review and merge path. The original branch is retained. See the continuation guide for active branches, dependencies and transition verification.